Override process importance for Session Replay integration tests#2304
Merged
Conversation
mariusc83
previously approved these changes
Oct 3, 2024
ambushwork
force-pushed
the
yl/it/fix-flaky
branch
from
October 3, 2024 09:37
cdbbb36 to
dbd8a5d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/sr-integration-test #2304 +/- ##
===============================================================
- Coverage 70.44% 70.23% -0.20%
===============================================================
Files 730 730
Lines 27268 27252 -16
Branches 4584 4583 -1
===============================================================
- Hits 19207 19140 -67
- Misses 6815 6841 +26
- Partials 1246 1271 +25 |
0xnm
approved these changes
Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In integration test, the process is always treated as foreground service instead of foreground.
So when initialising the feature,
DatadogRumMonitorconsider the app is not in foreground,which causes different test result in Rum feature.
In this case we need to force the importance of the process to have the same result of user environment.
Motivation
Fix flaky test
Review checklist (to be filled by reviewers)