Improve UT coverage for rum, logs and trace features#2299
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2299 +/- ##
===========================================
- Coverage 70.44% 70.36% -0.07%
===========================================
Files 730 730
Lines 27268 27264 -4
Branches 4584 4583 -1
===========================================
- Hits 19207 19184 -23
+ Misses 6815 6805 -10
- Partials 1246 1275 +29
|
0xnm
approved these changes
Oct 1, 2024
mariusc83
approved these changes
Oct 1, 2024
| } | ||
|
|
||
| @Test | ||
| fun `builder can disable the bundle with rum feature`() { |
Member
There was a problem hiding this comment.
why aren't we using the new test definitions pattern here ? Must...When
xgouchet
force-pushed
the
xgouchet/reliability/coverage_rum
branch
from
October 2, 2024 10:37
4160691 to
8ed116a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.