RUM-6194: Add Semantics Mapper for Button role#2296
Merged
Conversation
ambushwork
force-pushed
the
yl/compose/semantics-button-role
branch
from
September 27, 2024 13:19
5847e03 to
d675d8c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/sr_compose #2296 +/- ##
======================================================
- Coverage 69.58% 69.55% -0.04%
======================================================
Files 750 751 +1
Lines 27738 27809 +71
Branches 4732 4745 +13
======================================================
+ Hits 19301 19340 +39
- Misses 7105 7131 +26
- Partials 1332 1338 +6
|
ambushwork
force-pushed
the
yl/compose/semantics-button-role
branch
from
September 27, 2024 15:04
d675d8c to
6f18ec7
Compare
ambushwork
marked this pull request as ready for review
September 27, 2024 16:27
0xnm
previously approved these changes
Sep 27, 2024
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
nice to see how Jetpack Compose is finally getting a shape in Session Replay.
jonathanmos
previously approved these changes
Sep 30, 2024
mariusc83
previously approved these changes
Sep 30, 2024
xgouchet
previously approved these changes
Sep 30, 2024
ambushwork
dismissed stale reviews from xgouchet, mariusc83, jonathanmos, and 0xnm
via
September 30, 2024 11:13
8198b46
ambushwork
force-pushed
the
yl/compose/semantics-button-role
branch
from
September 30, 2024 11:13
6f18ec7 to
8198b46
Compare
ambushwork
force-pushed
the
yl/compose/semantics-button-role
branch
from
September 30, 2024 11:15
8198b46 to
afe85c6
Compare
0xnm
reviewed
Sep 30, 2024
0xnm
approved these changes
Sep 30, 2024
jonathanmos
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add Semantics Mapper for Button role
Motivation
RUM-6194
Demo
Review checklist (to be filled by reviewers)