Skip to content

RUM-6189: Add Abstract and Text semantics mapper for compose SR#2292

Merged
ambushwork merged 1 commit into
feature/sr_composefrom
yl/compose/semenatics-mapper
Sep 27, 2024
Merged

RUM-6189: Add Abstract and Text semantics mapper for compose SR#2292
ambushwork merged 1 commit into
feature/sr_composefrom
yl/compose/semenatics-mapper

Conversation

@ambushwork

@ambushwork ambushwork commented Sep 26, 2024

Copy link
Copy Markdown
Member

What does this PR do?

This is the commit to set up the framework to support Jetpack compose session replay with semantics solution.
In this commit the principals changes are:

  • Add AbstractSemanticsNodeMapper as the basic mapper providing some common functions for semantics mapping
  • Add TextSemanticsNodeMapper for the compose Text composable.
  • Now ComposeView will be mapped from ComposeWireframeMapper instead of SemanticsWireframeMapper.

Demo

Sample App Session replay
Screenshot 2024-09-26 at 23 20 54 image

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented Sep 26, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 55.97015% with 59 lines in your changes missing coverage. Please review.

Project coverage is 69.52%. Comparing base (6de40db) to head (fc14db6).
Report is 2 commits behind head on feature/sr_compose.

Files with missing lines Patch % Lines
...ernal/mappers/semantics/TextSemanticsNodeMapper.kt 48.53% 19 Missing and 16 partials ⚠️
...ionreplay/compose/internal/utils/SemanticsUtils.kt 11.11% 8 Missing ⚠️
...rnal/mappers/semantics/SemanticsWireframeMapper.kt 76.67% 3 Missing and 4 partials ⚠️
...l/mappers/semantics/AbstractSemanticsNodeMapper.kt 73.68% 4 Missing and 1 partial ⚠️
...y/compose/internal/reflection/ComposeReflection.kt 42.86% 0 Missing and 4 partials ⚠️
Additional details and impacted files 
@@                  Coverage Diff                   @@
##           feature/sr_compose    #2292      +/-   ##
======================================================
- Coverage               69.73%   69.52%   -0.20%     
======================================================
  Files                     746      750       +4     
  Lines                   27642    27742     +100     
  Branches                 4696     4733      +37     
======================================================
+ Hits                    19274    19287      +13     
- Misses                   7058     7120      +62     
- Partials                 1310     1335      +25
Files with missing lines Coverage Δ
...d/sessionreplay/compose/ComposeExtensionSupport.kt 92.31% <100.00%> (ø)
...y/compose/internal/reflection/ComposeReflection.kt 15.46% <42.86%> (+2.13%) ⬆️
...l/mappers/semantics/AbstractSemanticsNodeMapper.kt 73.68% <73.68%> (ø)
...rnal/mappers/semantics/SemanticsWireframeMapper.kt 76.67% <76.67%> (ø)
...ionreplay/compose/internal/utils/SemanticsUtils.kt 11.11% <11.11%> (ø)
...ernal/mappers/semantics/TextSemanticsNodeMapper.kt 48.53% <48.53%> (ø)

... and 33 files with indirect coverage changes

@ambushwork
ambushwork force-pushed the yl/compose/semenatics-mapper branch 2 times, most recently from b7b556c to 1ec890c Compare September 27, 2024 09:01
@ambushwork
ambushwork marked this pull request as ready for review September 27, 2024 09:54
@ambushwork
ambushwork requested review from a team as code owners September 27, 2024 09:54
0xnm
0xnm reviewed Sep 27, 2024
View reviewed changes
Comment thread detekt_custom.yml
Comment thread detekt_custom.yml Outdated
Comment thread features/dd-sdk-android-rum/api/dd-sdk-android-rum.api Outdated
Comment thread ...datadog/android/sessionreplay/compose/internal/mappers/semantics/SemanticsWireframeMapper.kt Outdated
Comment thread .../datadog/android/sessionreplay/compose/internal/mappers/semantics/TextSemanticsNodeMapper.kt Outdated
Comment thread .../datadog/android/sessionreplay/compose/internal/mappers/semantics/TextSemanticsNodeMapper.kt Outdated
Comment thread .../android/sessionreplay/compose/internal/mappers/semantics/AbstractSemanticsNodeMapperTest.kt Outdated
Comment thread .../android/sessionreplay/compose/internal/mappers/semantics/AbstractSemanticsNodeMapperTest.kt Outdated
Comment thread ...dog/android/sessionreplay/compose/internal/mappers/semantics/SemanticsWireframeMapperTest.kt Outdated
@ambushwork
ambushwork force-pushed the yl/compose/semenatics-mapper branch 2 times, most recently from 6c7c385 to 69681f8 Compare September 27, 2024 11:24
@ambushwork
ambushwork requested a review from 0xnm September 27, 2024 11:25
0xnm
0xnm previously approved these changes Sep 27, 2024
View reviewed changes

@0xnm 0xnm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@ambushwork
ambushwork force-pushed the yl/compose/semenatics-mapper branch from 69681f8 to fc14db6 Compare September 27, 2024 11:56
@ambushwork
ambushwork merged commit c37edce into feature/sr_compose Sep 27, 2024
@ambushwork
ambushwork deleted the yl/compose/semenatics-mapper branch September 27, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ambushwork @codecov-commenter @xgouchet @0xnm