Skip to content

RUM-6324: Add MaterialCardView support in Material SR extension#2290

Merged
ambushwork merged 1 commit into
developfrom
yl/sr/fix-card-view-background
Sep 27, 2024
Merged

RUM-6324: Add MaterialCardView support in Material SR extension#2290
ambushwork merged 1 commit into
developfrom
yl/sr/fix-card-view-background

Conversation

@ambushwork

@ambushwork ambushwork commented Sep 26, 2024

Copy link
Copy Markdown
Member

What does this PR do?

MaterialCardView is a widely used material component, this PR adds MaterialCardView support in Material SR extension

Motivation

RUM-6324

Demo

Sample Before After
image image image

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented Sep 26, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.02%. Comparing base (64ffa00) to head (ca11ab2).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...ionreplay/material/internal/CardWireframeMapper.kt 96.67% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2290      +/-   ##
===========================================
+ Coverage    69.93%   70.02%   +0.09%     
===========================================
  Files          732      732              
  Lines        27176    27262      +86     
  Branches      4574     4581       +7     
===========================================
+ Hits         19003    19089      +86     
  Misses        6894     6894              
  Partials      1279     1279              
Files with missing lines Coverage Δ
...sessionreplay/material/MaterialExtensionSupport.kt 100.00% <100.00%> (ø)
...ionreplay/material/internal/CardWireframeMapper.kt 96.67% <96.67%> (ø)

... and 29 files with indirect coverage changes

@ambushwork
ambushwork force-pushed the yl/sr/fix-card-view-background branch from 9ea8280 to ca11ab2 Compare September 26, 2024 12:21
@ambushwork
ambushwork marked this pull request as ready for review September 26, 2024 12:54
@ambushwork
ambushwork requested review from a team as code owners September 26, 2024 12:54
@ambushwork
ambushwork merged commit 84081cb into develop Sep 27, 2024
@ambushwork
ambushwork deleted the yl/sr/fix-card-view-background branch September 27, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants