Skip to content

RUM-6324: Add View Groups Session Replay demo screen in sample app#2285

Merged
ambushwork merged 1 commit into
developfrom
yl/sr/fix-card-view-background
Sep 25, 2024
Merged

RUM-6324: Add View Groups Session Replay demo screen in sample app#2285
ambushwork merged 1 commit into
developfrom
yl/sr/fix-card-view-background

Conversation

@ambushwork

@ambushwork ambushwork commented Sep 25, 2024

Copy link
Copy Markdown
Member

What does this PR do?

When testing SR with some other applications, we noticed that the card view is not correctly display in the player, before fixing the issue, we need to add an showcase screen for this kind of view groups.

Motivation

RUM-6324

Additional Notes

Sample App Player
Screenshot_20240925_135133 image

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork requested review from a team as code owners September 25, 2024 11:51
@codecov-commenter

codecov-commenter commented Sep 25, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (10e1da1) to head (3b952f4).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2285      +/-   ##
===========================================
- Coverage    70.05%   70.04%   -0.01%     
===========================================
  Files          732      732              
  Lines        27215    27195      -20     
  Branches      4577     4577              
===========================================
- Hits         19064    19048      -16     
- Misses        6869     6872       +3     
+ Partials      1282     1275       -7     

see 37 files with indirect coverage changes

@ambushwork
ambushwork merged commit f396920 into develop Sep 25, 2024
@ambushwork
ambushwork deleted the yl/sr/fix-card-view-background branch September 25, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants