RUM-6316: Remove Session Replay button mapper border#2280
Merged
Conversation
0xnm
approved these changes
Sep 24, 2024
ambushwork
force-pushed
the
yl/sr/remove-button-border
branch
from
September 24, 2024 12:46
420154c to
b5c485a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2280 +/- ##
===========================================
- Coverage 70.18% 70.03% -0.16%
===========================================
Files 732 732
Lines 27227 27192 -35
Branches 4580 4573 -7
===========================================
- Hits 19109 19042 -67
- Misses 6861 6873 +12
- Partials 1257 1277 +20
|
xgouchet
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove Session Replay button mapper border.
The logic before was adding a black border to every text view inside which doesn't have a shape or border, But text view mapper always return a wireframe without them, so the black border will always be applied, which doesn't correspond to the real UI.
Motivation
RUM-6316
Demo
Review checklist (to be filled by reviewers)