Skip to content

RUM-6314: Use layout text to display textview overflow correctly#2279

Merged
ambushwork merged 1 commit into
developfrom
yl/sr/use-layout-text
Sep 24, 2024
Merged

RUM-6314: Use layout text to display textview overflow correctly#2279
ambushwork merged 1 commit into
developfrom
yl/sr/use-layout-text

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

Fix the Session Replay issue that text view overflow could not be displayed properly

Motivation

RUM-6314

Demo

App screen Before After
image image image

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork force-pushed the yl/sr/use-layout-text branch from b27c758 to 150f273 Compare September 24, 2024 08:37
@ambushwork
ambushwork marked this pull request as ready for review September 24, 2024 08:43
@ambushwork
ambushwork requested review from a team as code owners September 24, 2024 08:43
@codecov-commenter

codecov-commenter commented Sep 24, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.02%. Comparing base (26c28e2) to head (21d5479).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...id/sessionreplay/recorder/mapper/TextViewMapper.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2279      +/-   ##
===========================================
- Coverage    70.18%   70.02%   -0.16%     
===========================================
  Files          732      732              
  Lines        27227    27225       -2     
  Branches      4580     4580              
===========================================
- Hits         19109    19064      -45     
- Misses        6861     6876      +15     
- Partials      1257     1285      +28     
Files with missing lines Coverage Δ
...id/sessionreplay/recorder/mapper/TextViewMapper.kt 90.00% <50.00%> (+0.10%) ⬆️

... and 25 files with indirect coverage changes

@ambushwork
ambushwork force-pushed the yl/sr/use-layout-text branch from 150f273 to 21d5479 Compare September 24, 2024 09:50
@ambushwork
ambushwork merged commit a115df3 into develop Sep 24, 2024
@ambushwork
ambushwork deleted the yl/sr/use-layout-text branch September 24, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants