Fix DatadogInterceptor flaky test#2274
Merged
Merged
Conversation
ambushwork
marked this pull request as ready for review
September 23, 2024 08:19
mariusc83
approved these changes
Sep 23, 2024
0xnm
requested changes
Sep 23, 2024
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
nice catch! but the same should be applied to the test above as well.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2274 +/- ##
===========================================
- Coverage 70.05% 70.01% -0.04%
===========================================
Files 732 732
Lines 27209 27198 -11
Branches 4579 4578 -1
===========================================
- Hits 19060 19042 -18
+ Misses 6876 6873 -3
- Partials 1273 1283 +10 |
xgouchet
approved these changes
Sep 23, 2024
Member
Author
@0xnm if I understand correctly, the test above specifically set the mimeType a stream content type, which will always be parsed as |
0xnm
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix DatadogInterceptor flaky test
Review checklist (to be filled by reviewers)