Do not use magic numbers in InternalLogger API#2271
Merged
Conversation
xgouchet
approved these changes
Sep 19, 2024
0xnm
approved these changes
Sep 19, 2024
mariusc83
force-pushed
the
mconstantin/small-api-fix-addviewloadingtime
branch
from
September 19, 2024 15:08
ab17e2a to
8038b2f
Compare
ambushwork
approved these changes
Sep 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2271 +/- ##
===========================================
+ Coverage 69.98% 70.02% +0.04%
===========================================
Files 731 731
Lines 27204 27211 +7
Branches 4574 4577 +3
===========================================
+ Hits 19037 19053 +16
+ Misses 6896 6874 -22
- Partials 1271 1284 +13
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)