RUM-6136: Randomize privacy levels to support Fine Grained Masking in E2E#2265
Merged
jonathanmos merged 1 commit intoSep 18, 2024
Merged
Conversation
jonathanmos
changed the title
jonathanmos
force-pushed
the
jmoskovich/rum-6136/update-android-e2e-for-fgm
branch
from
September 17, 2024 11:22
365c312 to
ddab0b1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2265 +/- ##
===========================================
- Coverage 70.06% 70.05% -0.01%
===========================================
Files 730 730
Lines 27181 27193 +12
Branches 4593 4591 -2
===========================================
+ Hits 19043 19048 +5
Misses 6845 6845
- Partials 1293 1300 +7 |
jonathanmos
marked this pull request as ready for review
September 18, 2024 08:09
0xnm
approved these changes
Sep 18, 2024
ambushwork
approved these changes
Sep 18, 2024
jonathanmos
deleted the
jmoskovich/rum-6136/update-android-e2e-for-fgm
branch
September 18, 2024 10:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Apply the same logic that we have in Shopist, so that the android sample application will also randomize privacy for session replay. 10% of sessions will be fine grained masking sessions.
This pr includes a small cleanup of the sampleApplication class.
Motivation
Part of dogfooding fine grained masking.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)