Skip to content

Explicitly set antlr-runtime transitive dependency version#2261

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/explicitly-set-antlr-runtime-version
Sep 12, 2024
Merged

Explicitly set antlr-runtime transitive dependency version#2261
0xnm merged 1 commit into
developfrom
nogorodnikov/explicitly-set-antlr-runtime-version

Conversation

@0xnm

@0xnm 0xnm commented Sep 12, 2024

Copy link
Copy Markdown
Member

What does this PR do?

The transitive version used com.github.drieks.antlr-kotlin:antlr-kotlin-runtime:d4384e4d90 cannot be found on Jitpack anymore, causing the build to fail. So specifying the version explicitly, with the one which can be found.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners September 12, 2024 13:00
@codecov-commenter

codecov-commenter commented Sep 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.06%. Comparing base (72adfba) to head (daaa233).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2261      +/-   ##
===========================================
- Coverage    70.11%   70.06%   -0.05%     
===========================================
  Files          730      730              
  Lines        27192    27192              
  Branches      4590     4590              
===========================================
- Hits         19063    19050      -13     
- Misses        6838     6844       +6     
- Partials      1291     1298       +7     

see 27 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants