Skip to content

RUM-5184: Add dynamic optimization field in SessionReplayConfiguration#2259

Merged
ambushwork merged 1 commit into
feature/sr-dynamic-optimisationfrom
yl/sr-opt/add-flag
Sep 17, 2024
Merged

RUM-5184: Add dynamic optimization field in SessionReplayConfiguration#2259
ambushwork merged 1 commit into
feature/sr-dynamic-optimisationfrom
yl/sr-opt/add-flag

Conversation

@ambushwork

@ambushwork ambushwork commented Sep 11, 2024

Copy link
Copy Markdown
Member

What does this PR do?

[Adding API changes] Add dynamic optimization field in SessionReplayConfiguration

Motivation

RUM-5184

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork requested review from a team as code owners September 11, 2024 12:01
@codecov-commenter

codecov-commenter commented Sep 11, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.13%. Comparing base (114cd63) to head (263dac8).
Report is 7 commits behind head on feature/sr-dynamic-optimisation.

Files with missing lines Patch % Lines
...internal/recorder/DefaultOnDrawListenerProducer.kt 50.00% 2 Missing ⚠️
...nternal/recorder/listener/WindowsOnDrawListener.kt 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@                         Coverage Diff                         @@
##           feature/sr-dynamic-optimisation    #2259      +/-   ##
===================================================================
+ Coverage                            70.09%   70.13%   +0.04%     
===================================================================
  Files                                  730      731       +1     
  Lines                                27192    27239      +47     
  Branches                              4590     4598       +8     
===================================================================
+ Hits                                 19058    19102      +44     
- Misses                                6841     6847       +6     
+ Partials                              1293     1290       -3
Files with missing lines Coverage Δ
...com/datadog/android/sessionreplay/SessionReplay.kt 54.17% <100.00%> (+1.99%) ⬆️
...ndroid/sessionreplay/SessionReplayConfiguration.kt 100.00% <100.00%> (ø)
.../sessionreplay/internal/DefaultRecorderProvider.kt 93.55% <100.00%> (+0.11%) ⬆️
...oid/sessionreplay/internal/SessionReplayFeature.kt 98.73% <100.00%> (+0.01%) ⬆️
...droid/sessionreplay/internal/recorder/Debouncer.kt 96.67% <100.00%> (-3.33%) ⬇️
...nreplay/internal/recorder/SessionReplayRecorder.kt 96.92% <100.00%> (+0.02%) ⬆️
...internal/recorder/DefaultOnDrawListenerProducer.kt 35.71% <50.00%> (+2.38%) ⬆️
...nternal/recorder/listener/WindowsOnDrawListener.kt 92.11% <33.33%> (-5.12%) ⬇️

... and 28 files with indirect coverage changes

0xnm
0xnm reviewed Sep 11, 2024
View reviewed changes
Comment thread ...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt Outdated
Comment thread ...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt Outdated
mariusc83
mariusc83 previously approved these changes Sep 12, 2024
View reviewed changes
jonathanmos
jonathanmos previously approved these changes Sep 12, 2024
View reviewed changes
Comment thread ...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt Outdated
@ambushwork
ambushwork dismissed stale reviews from jonathanmos and mariusc83 via 6cd2fb2 September 12, 2024 09:00
@ambushwork
ambushwork force-pushed the yl/sr-opt/add-flag branch 7 times, most recently from 63e3714 to 7c8412e Compare September 13, 2024 08:25
0xnm
0xnm previously approved these changes Sep 13, 2024
View reviewed changes

@0xnm 0xnm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments/suggestions, but overall lgtm. I'm not sure about the parameter description, it is better to check with @jonathanmos.

Comment thread ...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt
Comment thread ...y/src/test/kotlin/com/datadog/android/sessionreplay/SessionReplayConfigurationBuilderTest.kt Outdated
Comment thread ...-replay/src/test/kotlin/com/datadog/android/sessionreplay/internal/recorder/DebouncerTest.kt Outdated
jonathanmos
jonathanmos previously approved these changes Sep 16, 2024
View reviewed changes

@jonathanmos jonathanmos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for minor comments

Comment thread ...-replay/src/test/kotlin/com/datadog/android/sessionreplay/internal/recorder/DebouncerTest.kt Outdated
Comment thread ...ssion-replay/src/main/kotlin/com/datadog/android/sessionreplay/SessionReplayConfiguration.kt Outdated
jonathanmos
jonathanmos previously approved these changes Sep 16, 2024
View reviewed changes
@ambushwork
ambushwork merged commit 35991f3 into feature/sr-dynamic-optimisation Sep 17, 2024
@ambushwork
ambushwork deleted the yl/sr-opt/add-flag branch September 17, 2024 07:52
@jonathanmos jonathanmos mentioned this pull request Sep 30, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanmos jonathanmos jonathanmos approved these changes
@mariusc83 mariusc83 Awaiting requested review from mariusc83
@0xnm 0xnm Awaiting requested review from 0xnm
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ambushwork @codecov-commenter @xgouchet @mariusc83 @0xnm @jonathanmos