RUM-6104 ensure UploadWorker uses the sdk instance name#2257
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2257 +/- ##
===========================================
- Coverage 69.98% 69.97% -0.01%
===========================================
Files 728 728
Lines 27063 27051 -12
Branches 4561 4560 -1
===========================================
- Hits 18939 18927 -12
- Misses 6841 6846 +5
+ Partials 1283 1278 -5
|
0xnm
approved these changes
Sep 11, 2024
| assertThat(testedCore.isDeveloperModeEnabled).isFalse() | ||
| } | ||
|
|
||
| @RepeatedTest(128) |
Member
There was a problem hiding this comment.
Shouldn't it be just @Test here? Is it needed to repeat it so many times?
Contributor
Author
There was a problem hiding this comment.
You're right, i used it locally :D
Member
|
Question: in the description of the PR it says before the fix, ".. meaning that for applications specifying an instance name would never find a relevant SDK." I wonder how |
…rkRequest for that specific instance
xgouchet
force-pushed
the
xgouchet/RUM-6104/upload_worker_instance_name
branch
from
September 11, 2024 09:05
7bcbc27 to
cefc19c
Compare
ambushwork
approved these changes
Sep 11, 2024
mariusc83
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When the UploadWorker is woken by the system, it reads the SDK Instance name from the WorkRequest input data, and tries to get the instance with that name.
However, the instance name was never sent meaning that for applications specifying an instance name would never find a relevant SDK.
Motivation
Fixes #2252