Skip to content

RUM-5188: Add session replay skipped frames count in session ended metrics#2256

Merged
ambushwork merged 1 commit into
feature/sr-dynamic-optimisationfrom
yl/sr-opt/frame-telemetry
Sep 11, 2024
Merged

RUM-5188: Add session replay skipped frames count in session ended metrics#2256
ambushwork merged 1 commit into
feature/sr-dynamic-optimisationfrom
yl/sr-opt/frame-telemetry

Conversation

@ambushwork

@ambushwork ambushwork commented Sep 10, 2024

Copy link
Copy Markdown
Member

What does this PR do?

Add session replay skipped frames count in session ended metrics, so that we can have a visibility in RUM telemetry how many frames are optimised by the time bank.

Motivation

RUM-5188

Demo

Screenshot 2024-09-09 at 15 40 14

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork requested review from a team as code owners September 10, 2024 14:40
@codecov-commenter

codecov-commenter commented Sep 10, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.05%. Comparing base (e0dd0d4) to head (315ebd7).
Report is 2 commits behind head on feature/sr-dynamic-optimisation.

Files with missing lines Patch % Lines
...lin/com/datadog/android/rum/internal/RumFeature.kt 0.00% 1 Missing and 1 partial ⚠️
...um/internal/metric/SessionEndedMetricDispatcher.kt 0.00% 0 Missing and 1 partial ⚠️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 75.00% 0 Missing and 1 partial ⚠️
...droid/sessionreplay/internal/recorder/Debouncer.kt 80.00% 0 Missing and 1 partial ⚠️
...internal/recorder/DefaultOnDrawListenerProducer.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                         Coverage Diff                         @@
##           feature/sr-dynamic-optimisation    #2256      +/-   ##
===================================================================
+ Coverage                            70.00%   70.05%   +0.06%     
===================================================================
  Files                                  728      728              
  Lines                                27049    27091      +42     
  Branches                              4560     4567       +7     
===================================================================
+ Hits                                 18933    18978      +45     
+ Misses                                6842     6829      -13     
- Partials                              1274     1284      +10
Files with missing lines Coverage Δ
.../android/rum/internal/metric/SessionEndedMetric.kt 93.75% <100.00%> (+0.20%) ⬆️
...android/rum/internal/monitor/AdvancedRumMonitor.kt 66.67% <ø> (ø)
...nternal/recorder/listener/WindowsOnDrawListener.kt 97.22% <100.00%> (ø)
...um/internal/metric/SessionEndedMetricDispatcher.kt 65.62% <0.00%> (-2.12%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 87.43% <75.00%> (+0.15%) ⬆️
...droid/sessionreplay/internal/recorder/Debouncer.kt 96.30% <80.00%> (+14.81%) ⬆️
...internal/recorder/DefaultOnDrawListenerProducer.kt 33.33% <0.00%> (ø)
...lin/com/datadog/android/rum/internal/RumFeature.kt 93.33% <0.00%> (-0.87%) ⬇️

... and 31 files with indirect coverage changes

0xnm
0xnm reviewed Sep 10, 2024
View reviewed changes
Comment thread ...dk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/metric/SessionEndedMetric.kt Outdated
Comment thread ...oid-rum/src/test/kotlin/com/datadog/android/rum/internal/metric/RumSessionEndedMetricTest.kt Outdated
Comment thread features/dd-sdk-android-session-replay/build.gradle.kts Outdated
Comment thread ...sion-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/recorder/Debouncer.kt Outdated
Comment thread ...sion-replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/recorder/Debouncer.kt Outdated
@ambushwork
ambushwork force-pushed the yl/sr-opt/frame-telemetry branch from 41135bb to 0003db8 Compare September 10, 2024 15:27
xgouchet
xgouchet previously approved these changes Sep 11, 2024
View reviewed changes
Comment thread ...dk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/metric/SessionEndedMetric.kt Outdated
Comment thread ...droid-rum/src/main/kotlin/com/datadog/android/rum/internal/metric/SessionMetricDispatcher.kt Outdated
@ambushwork
ambushwork force-pushed the yl/sr-opt/frame-telemetry branch from 0003db8 to 8361634 Compare September 11, 2024 07:49
jonathanmos
jonathanmos previously approved these changes Sep 11, 2024
View reviewed changes
@ambushwork
ambushwork requested review from 0xnm and xgouchet September 11, 2024 08:02
0xnm
0xnm previously approved these changes Sep 11, 2024
View reviewed changes
Comment thread ...oid-rum/src/test/kotlin/com/datadog/android/rum/internal/metric/RumSessionEndedMetricTest.kt Outdated
@ambushwork
ambushwork dismissed stale reviews from 0xnm and jonathanmos via 03acf82 September 11, 2024 08:12
@ambushwork
ambushwork force-pushed the yl/sr-opt/frame-telemetry branch 2 times, most recently from 03acf82 to b901950 Compare September 11, 2024 08:36
0xnm
0xnm previously approved these changes Sep 11, 2024
View reviewed changes
@ambushwork
ambushwork force-pushed the yl/sr-opt/frame-telemetry branch from b901950 to 315ebd7 Compare September 11, 2024 09:48
@ambushwork
ambushwork merged commit 4816f62 into feature/sr-dynamic-optimisation Sep 11, 2024
@ambushwork
ambushwork deleted the yl/sr-opt/frame-telemetry branch September 11, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@xgouchet xgouchet Awaiting requested review from xgouchet
@jonathanmos jonathanmos Awaiting requested review from jonathanmos

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ambushwork @codecov-commenter @xgouchet @0xnm @jonathanmos