RUM-5761: Send fine grained masking instead of legacy privacy in config telemetry#2253
Merged
jonathanmos merged 1 commit intoSep 9, 2024
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-5761/fix-config-telemetry
branch
from
September 9, 2024 08:47
e4e9f0d to
bdfa827
Compare
jonathanmos
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/fine-grained-masking #2253 +/- ##
================================================================
+ Coverage 70.02% 70.10% +0.08%
================================================================
Files 729 729
Lines 27142 27174 +32
Branches 4582 4587 +5
================================================================
+ Hits 19006 19050 +44
+ Misses 6845 6836 -9
+ Partials 1291 1288 -3
|
jonathanmos
marked this pull request as ready for review
September 9, 2024 10:05
0xnm
approved these changes
Sep 9, 2024
ambushwork
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the legacy privacy from config telemetry - now we will send only the three fine grained privacy levels. This aligns the config telemetry behavior with ios.
Motivation
Part of the fine grained masking global privacy feature.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)