RUM-6096: Fix placeholder dimensions#2248
Merged
jonathanmos merged 1 commit intoSep 9, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/fine-grained-masking #2248 +/- ##
================================================================
+ Coverage 70.04% 70.08% +0.04%
================================================================
Files 729 729
Lines 27173 27169 -4
Branches 4588 4588
================================================================
+ Hits 19033 19041 +8
+ Misses 6846 6832 -14
- Partials 1294 1296 +2
|
jonathanmos
marked this pull request as ready for review
September 8, 2024 11:27
0xnm
approved these changes
Sep 9, 2024
xgouchet
approved these changes
Sep 9, 2024
jonathanmos
deleted the
jmoskovich/rum-6096/fix-placeholder-dimensions
branch
September 9, 2024 07:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix placeholder dimensions, which at the moment could cover the entire dimensions of the view in cases where there are compound drawables. This issue became noticeable with fine grained masking when users can mask all images.
Before fix:
After fix:
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)