RUM-6093:Add TimeBank in session replay recorder for dynamic optimisation#2247
Merged
Merged
Conversation
0xnm
reviewed
Sep 9, 2024
xgouchet
reviewed
Sep 9, 2024
| if (timePassedSinceLastExecution >= maxRecordDelayInNs) { | ||
| executeRunnable(runnable) | ||
| } else { | ||
| handler.postDelayed({ executeRunnable(runnable) }, DEBOUNCE_TIME_IN_MS) |
Contributor
There was a problem hiding this comment.
Warning
Shouldn't you remove previously posted runnables, if there are multiple debounced executions ?
Member
Author
There was a problem hiding this comment.
You are right, so I changed the place where runInTimeBalance should wrap up.
Now runInTimeBalance wrap only the function of executeRunnable, so we check first the condition of debounce frequency, then check if it meets the time balance.
mariusc83
reviewed
Sep 9, 2024
| if (timePassedSinceLastExecution >= maxRecordDelayInNs) { | ||
| executeRunnable(runnable) | ||
| } else { | ||
| handler.postDelayed({ executeRunnable(runnable) }, DEBOUNCE_TIME_IN_MS) |
ambushwork
force-pushed
the
yl/sr-opt/cpu-bank
branch
2 times, most recently
from
September 9, 2024 08:32
ff54810 to
fe0410a
Compare
mariusc83
reviewed
Sep 9, 2024
ambushwork
force-pushed
the
yl/sr-opt/cpu-bank
branch
2 times, most recently
from
September 9, 2024 13:42
8d854e7 to
705fa22
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/sr-dynamic-optimisation #2247 +/- ##
===================================================================
- Coverage 70.12% 69.99% -0.13%
===================================================================
Files 727 728 +1
Lines 27062 27077 +15
Branches 4560 4561 +1
===================================================================
- Hits 18975 18951 -24
- Misses 6827 6842 +15
- Partials 1260 1284 +24
|
mariusc83
previously approved these changes
Sep 9, 2024
0xnm
previously approved these changes
Sep 10, 2024
Comment on lines
+106
to
+107
| fun `M allow everything W set max balance to 1000ms per sec`(forge: Forge) { | ||
| recordingTimeBank = RecordingTimeBank(1000) |
Member
There was a problem hiding this comment.
what if it is more than 1s? shouldn't we cover this as well?
Member
Author
There was a problem hiding this comment.
Indeed, I updated the test to M allow everything W set max balance more than 1000ms per sec with a random value with 1000ms as min value.
jonathanmos
previously approved these changes
Sep 10, 2024
ambushwork
dismissed stale reviews from jonathanmos, 0xnm, and mariusc83
via
September 10, 2024 13:02
86dac33
ambushwork
force-pushed
the
yl/sr-opt/cpu-bank
branch
from
September 10, 2024 13:02
705fa22 to
86dac33
Compare
0xnm
approved these changes
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add TimeBank in session replay recorder for dynamic optimisation.
The main idea is to have a time balance in this
TimeBank, every execution of session replay recording will consume this balance, and the balance will be recharged during the time passing until a maximum balance is reached.Before every execution of recording, if the balance is negative, the execution will skipped until the balance is recharged to positive.
Motivation
RUM-6093
Review checklist (to be filled by reviewers)