RUM-5985: Add isContainer attribute to session replay span#2244
Merged
Conversation
ambushwork
force-pushed
the
yl/profiling/add-containter-tag
branch
3 times, most recently
from
September 5, 2024 15:45
780d9b8 to
ee1ed46
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2244 +/- ##
===========================================
- Coverage 70.00% 69.99% -0.02%
===========================================
Files 727 728 +1
Lines 27041 27054 +13
Branches 4560 4559 -1
===========================================
+ Hits 18930 18935 +5
- Misses 6831 6843 +12
+ Partials 1280 1276 -4
|
xgouchet
reviewed
Sep 5, 2024
0xnm
reviewed
Sep 6, 2024
ambushwork
force-pushed
the
yl/profiling/add-containter-tag
branch
from
September 6, 2024 07:34
ee1ed46 to
8380c4f
Compare
xgouchet
reviewed
Sep 6, 2024
| /** | ||
| * A wrap function of [withinBenchmarkSpan] dedicated to session replay span recording. | ||
| */ | ||
| internal inline fun <T : Any?> withinBenchmarkSpan( |
Contributor
There was a problem hiding this comment.
Note
As it's a version dedicated for SR, and to easily disambiguate between this helper and the base method, maybe we could name it withinSRBenchmarkSpan instead, WDYT?
ambushwork
force-pushed
the
yl/profiling/add-containter-tag
branch
from
September 6, 2024 12:25
8380c4f to
73d8245
Compare
0xnm
approved these changes
Sep 6, 2024
xgouchet
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a "isContainer" attribute into session replay span request to differentiate the components and containers view.
Motivation
In the benchmark dashboard, we want to have a top list graph to see which components take the leads of the time consumption in SR. here is the current graph:
As we can see the top list is occupied by the containers, which doesn't what we expect. Because containers' spans contain the children view, so we want to have only real components here.
Demo
After adding this attributes, we can differentiate them by adding filter
@attribute.container:falseAdd we got pure components span in the list
Review checklist (to be filled by reviewers)