RUM-6060 stop upload worker on upload failure#2242
Merged
xgouchet merged 1 commit intoSep 6, 2024
Conversation
xgouchet
force-pushed
the
xgouchet/RUM-6060/prevent_upload_worker_loop
branch
from
September 5, 2024 12:35
0134f17 to
9c74e12
Compare
0xnm
previously approved these changes
Sep 5, 2024
jonathanmos
previously approved these changes
Sep 5, 2024
xgouchet
force-pushed
the
xgouchet/RUM-6060/prevent_upload_worker_loop
branch
from
September 5, 2024 14:43
9c74e12 to
b3b46f5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2.13.0 #2242 +/- ##
==================================================
- Coverage 70.14% 69.97% -0.17%
==================================================
Files 727 727
Lines 27051 27047 -4
Branches 4558 4559 +1
==================================================
- Hits 18973 18924 -49
- Misses 6816 6840 +24
- Partials 1262 1283 +21
|
mariusc83
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR stops a potential infinite loop in some rare case. The upload worker is waken up after the application exits or crashes to send the remaining events to Datadog. Unfortunately it pulls the available batches one at a time, in a loop, and in some situations, an error would not lead to the batch being discarded, which could lead to looping over the same batch until it succeeds.