RUM-5761: Add TextAndInputPrivacy#2235
Merged
jonathanmos merged 1 commit intoSep 5, 2024
Merged
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-5761/text-privacy
branch
2 times, most recently
from
September 3, 2024 15:12
f946440 to
482ba4a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/fine-grained-masking #2235 +/- ##
================================================================
+ Coverage 69.98% 70.09% +0.12%
================================================================
Files 728 729 +1
Lines 27101 27161 +60
Branches 4574 4584 +10
================================================================
+ Hits 18964 19038 +74
+ Misses 6848 6829 -19
- Partials 1289 1294 +5
|
ambushwork
previously approved these changes
Sep 4, 2024
jonathanmos
marked this pull request as ready for review
September 4, 2024 13:47
xgouchet
previously approved these changes
Sep 5, 2024
jonathanmos
dismissed stale reviews from xgouchet and ambushwork
via
September 5, 2024 14:30
a8ce83a
jonathanmos
force-pushed
the
jmoskovich/rum-5761/text-privacy
branch
from
September 5, 2024 14:30
482ba4a to
a8ce83a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Notice that this PR is being merged into the feature branch and not yet into develop.)
Adds the new setTextAndInputPrivacy api and deprecates the setPrivacy api.
When a user calls setPrivacy it will be converted into the new fine grained masking levels.
allow -> text: mask_sensitive_inputs, images: mask_none, touch: show
mask_user_input -> text: mask_all_inputs, images: mask_large_only, touch: hide
mask -> text: mask_all, images: mask_all, touch: hide
When passing to the webviews the fine grained masking is converted back to the legacy privacy levels in such a way as to be at least as restrictive as necessary. In practice this means it is almost always converted to mask_all. The two exceptions are:
text: mask_sensitive_text, images: mask_none, touch: show --> allow
text: mask_user_input, images: mask_none, touch: show --> mask_input
In addition, we will send the new fine grained masking apis in the configuration telemetry.
Motivation
Fine grained masking global configuration.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)