Update benchmark metrics memory reader probe interval#2228
Merged
Conversation
0xnm
reviewed
Sep 2, 2024
mariusc83
requested changes
Sep 2, 2024
ambushwork
force-pushed
the
yl/metrics/fix-memory-probe
branch
3 times, most recently
from
September 2, 2024 14:53
c7ad39a to
7bb64f2
Compare
ambushwork
force-pushed
the
yl/metrics/fix-memory-probe
branch
from
September 3, 2024 09:59
7bb64f2 to
88e0b66
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2228 +/- ##
===========================================
- Coverage 70.12% 69.97% -0.16%
===========================================
Files 727 727
Lines 27052 27013 -39
Branches 4558 4551 -7
===========================================
- Hits 18970 18900 -70
- Misses 6818 6829 +11
- Partials 1264 1284 +20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update benchmark metrics memory reader probe interval
Logic changes:
readVitalData()is called every 10 seconds.readVitalDatais called to output this result.Review checklist (to be filled by reviewers)