RUM-5977 add configuration to set uploadSchedulerStrategy#2224
Merged
xgouchet merged 1 commit intoSep 3, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2224 +/- ##
===========================================
- Coverage 70.02% 69.95% -0.07%
===========================================
Files 727 727
Lines 27036 27020 -16
Branches 4556 4551 -5
===========================================
- Hits 18931 18901 -30
- Misses 6828 6842 +14
Partials 1277 1277
|
0xnm
reviewed
Sep 2, 2024
| * @param uploadSchedulerStrategy the upload scheduler strategy, | ||
| * or null to use the default strategy (default: null) | ||
| */ | ||
| fun setUploadScheduledStrategy(uploadSchedulerStrategy: UploadSchedulerStrategy?): Builder { |
Member
There was a problem hiding this comment.
Should it be called setUploadSchedulerStrategy?
Suggested change
| fun setUploadScheduledStrategy(uploadSchedulerStrategy: UploadSchedulerStrategy?): Builder { | |
| fun setUploadSchedulerStrategy(uploadSchedulerStrategy: UploadSchedulerStrategy?): Builder { |
xgouchet
force-pushed
the
xgouchet/RUM-5977/configure_custom_upload_scheduler_strategy
branch
from
September 2, 2024 08:33
39d68ca to
aaf2050
Compare
0xnm
approved these changes
Sep 2, 2024
jonathanmos
approved these changes
Sep 2, 2024
xgouchet
force-pushed
the
xgouchet/RUM-5977/configure_custom_upload_scheduler_strategy
branch
from
September 3, 2024 08:14
aaf2050 to
128721c
Compare
xgouchet
deleted the
xgouchet/RUM-5977/configure_custom_upload_scheduler_strategy
branch
September 3, 2024 09:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Let customer chose their UploadSchedulerStrategy