Make Image Privacy a public api#2204
Merged
jonathanmos merged 1 commit intoAug 21, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/fine-grained-masking #2204 +/- ##
================================================================
- Coverage 69.99% 69.97% -0.02%
================================================================
Files 726 726
Lines 27050 27046 -4
Branches 4543 4542 -1
================================================================
- Hits 18931 18924 -7
Misses 6837 6837
- Partials 1282 1285 +3
|
jonathanmos
marked this pull request as ready for review
August 20, 2024 11:37
ambushwork
approved these changes
Aug 20, 2024
mariusc83
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
• Expose Image Privacy as a public api on the feature branch as part of fine grained masking (in develop it's still an internal api).
• Also change the default masking level to MASK_ALL as per the RFC.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)