Skip to content

RUM-673: Log Timber tag#2202

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-673/log-timber-tag
Aug 20, 2024
Merged

RUM-673: Log Timber tag#2202
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-673/log-timber-tag

Conversation

@0xnm

@0xnm 0xnm commented Aug 20, 2024

Copy link
Copy Markdown
Member

What does this PR do?

Resolves #2195. If Timber tag is present, it will be logged as timber.tag attribute.

image

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners August 20, 2024 08:03
@codecov-commenter

codecov-commenter commented Aug 20, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.02%. Comparing base (fa45cbf) to head (121c89a).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2202      +/-   ##
===========================================
+ Coverage    69.90%   70.02%   +0.13%     
===========================================
  Files          726      726              
  Lines        27002    26985      -17     
  Branches      4527     4523       -4     
===========================================
+ Hits         18874    18896      +22     
+ Misses        6850     6813      -37     
+ Partials      1278     1276       -2     
Files Coverage Δ
...n/kotlin/com/datadog/android/timber/DatadogTree.kt 64.29% <100.00%> (+14.29%) ⬆️

... and 38 files with indirect coverage changes

@0xnm
0xnm force-pushed the nogorodnikov/rum-673/log-timber-tag branch from 85d199f to 121c89a Compare August 20, 2024 08:55
@0xnm
0xnm requested a review from mariusc83 August 20, 2024 08:55
@0xnm
0xnm merged commit 7bcd7bd into develop Aug 20, 2024
@0xnm
0xnm deleted the nogorodnikov/rum-673/log-timber-tag branch August 20, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TImber Tags are Ignored

3 participants