RUM-5763: Add TouchPrivacy to Session Replay#2196
Merged
jonathanmos merged 1 commit intoSep 2, 2024
Merged
Conversation
jonathanmos
changed the title
jonathanmos
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/fine-grained-masking #2196 +/- ##
================================================================
+ Coverage 69.94% 70.01% +0.07%
================================================================
Files 726 727 +1
Lines 27026 27015 -11
Branches 4543 4535 -8
================================================================
+ Hits 18902 18912 +10
+ Misses 6842 6834 -8
+ Partials 1282 1269 -13
|
jonathanmos
marked this pull request as ready for review
August 15, 2024 14:07
mariusc83
requested changes
Aug 19, 2024
jonathanmos
changed the base branch from
develop
to
feature/fine-grained-masking
August 19, 2024 09:06
jonathanmos
force-pushed
the
jmoskovich/rum-5763/touch-privacy
branch
from
August 19, 2024 11:31
6837edc to
79a1010
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-5763/touch-privacy
branch
2 times, most recently
from
August 20, 2024 11:06
5a85ca9 to
4136c1f
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-5763/touch-privacy
branch
from
August 22, 2024 07:23
4136c1f to
52c56c2
Compare
0xnm
approved these changes
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a public TouchPrivacy api
Possible values for touch:
SHOW- record all touch interactionsHIDE- do not record touch interactionsDefault value will be HIDE.
Usage example:
Note: At the moment this will not hide the change in a button background that occurs as a result of a click (or other view hierarchy side effects).
Motivation
Part of the move to fine grained privacy options.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)