Use adb install -g flag only for Android API above 23#2193
Merged
0xnm merged 1 commit intoAug 14, 2024
Merged
Conversation
mariusc83
approved these changes
Aug 14, 2024
Base automatically changed from
nogorodnikov/rum-5831/speed-up-generated-files-check
to
develop
August 14, 2024 12:26
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2193 +/- ##
===========================================
+ Coverage 69.92% 70.01% +0.09%
===========================================
Files 726 726
Lines 26991 27005 +14
Branches 4526 4527 +1
===========================================
+ Hits 18871 18906 +35
+ Misses 6842 6829 -13
+ Partials 1278 1270 -8 |
0xnm
marked this pull request as ready for review
August 14, 2024 12:53
jonathanmos
approved these changes
Aug 14, 2024
0xnm
deleted the
nogorodnikov/use-adb-install-g-flag-only-for-android-above-23
branch
August 14, 2024 13:08
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It doesn't work with Android below 23, giving
Error: Unknown option: -gand resulting in the installation failure.Review checklist (to be filled by reviewers)