RUM-5831: Speed up generated files/licenses checks#2188
Merged
0xnm merged 1 commit intoAug 14, 2024
Conversation
0xnm
force-pushed
the
nogorodnikov/rum-5831/speed-up-generated-files-check
branch
from
August 13, 2024 09:28
16fdabf to
0ea6d7c
Compare
Base automatically changed from
nogorodnikov/speed-up-idgenerationstrategy-test
to
develop
August 13, 2024 09:55
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2188 +/- ##
===========================================
- Coverage 70.02% 69.92% -0.10%
===========================================
Files 726 726
Lines 27005 26991 -14
Branches 4527 4526 -1
===========================================
- Hits 18908 18871 -37
- Misses 6827 6842 +15
- Partials 1270 1278 +8 |
0xnm
force-pushed
the
nogorodnikov/rum-5831/speed-up-generated-files-check
branch
from
August 14, 2024 10:42
89822c4 to
877ce88
Compare
0xnm
force-pushed
the
nogorodnikov/rum-5831/speed-up-generated-files-check
branch
from
August 14, 2024 10:47
877ce88 to
881eb39
Compare
0xnm
marked this pull request as ready for review
August 14, 2024 10:58
mariusc83
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
generated-files-checkjob takes 30+ minutes on the CI (link). It is essentially a gradle taskcheckGeneratedFilesin our case which runs licenses check, API surface check and transitive dependencies check. The main bottleneck is the task to check licenses.With https://github.com/DataDog/gradle-dependency-license-plugin/pull/19 merged and released the job now takes only 8 minutes, so it is 4 times faster.
It is essentially possible to improve the change in the PR mentioned above by sharing the cache between the projects, but the current gain is already good enough for our needs (Detekt run with custom rules in the same stage takes 7+ minutes).
Review checklist (to be filled by reviewers)