Speed up IdGenerationStrategy test#2187
Merged
Merged
Conversation
mariusc83
approved these changes
Aug 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2187 +/- ##
===========================================
+ Coverage 69.96% 69.99% +0.03%
===========================================
Files 726 726
Lines 26978 26997 +19
Branches 4524 4523 -1
===========================================
+ Hits 18875 18896 +21
+ Misses 6831 6829 -2
Partials 1272 1272 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
M generate id with strategyName and tIdSize bitstest was taking almost 1 minute to run on my machine (takes even more on CI), so speeding it up by lowering down the number of trace IDs being generated.Review checklist (to be filled by reviewers)