Skip to content

RUM-5830: Make no-op RUM monitor implementation returned by default to be NoOpAdvancedRumMonitor#2185

Merged
0xnm merged 1 commit into
release/2.12.0from
nogorodnikov/rum-5830/fix-classcastexception-in-datadoginterceptor
Aug 13, 2024
Merged

RUM-5830: Make no-op RUM monitor implementation returned by default to be NoOpAdvancedRumMonitor#2185
0xnm merged 1 commit into
release/2.12.0from
nogorodnikov/rum-5830/fix-classcastexception-in-datadoginterceptor

Conversation

@0xnm

@0xnm 0xnm commented Aug 13, 2024

Copy link
Copy Markdown
Member

What does this PR do?

Fixes #2183.

#2126 introduced some changes and now we need to have an instance of AdvancedRumMonitor for OkHttp instrumentation.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners August 13, 2024 08:26
@0xnm
0xnm merged commit bbc7612 into release/2.12.0 Aug 13, 2024
@0xnm
0xnm deleted the nogorodnikov/rum-5830/fix-classcastexception-in-datadoginterceptor branch August 13, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants