RUM-5780:Use SurfaceCompoitionGroupMapper to support container components in SR#2182
Merged
ambushwork merged 2 commits intoAug 13, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/sr_compose #2182 +/- ##
======================================================
+ Coverage 82.30% 82.35% +0.06%
======================================================
Files 514 514
Lines 18353 18348 -5
Branches 2821 2821
======================================================
+ Hits 15104 15110 +6
+ Misses 2488 2474 -14
- Partials 761 764 +3
|
0xnm
previously approved these changes
Aug 12, 2024
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
minor doc edit suggestion, otherwise lgtm.
Comment on lines
+16
to
+21
| /** | ||
| * This class is responsible to map the Jetpack compose components which have "backgroundColor" & "contentColor" | ||
| * in the parameter list, these components are mostly container components such as [BottomNavigation], [TopAppBar] | ||
| * and [TabRow], etc.., they usually have a [Surface] implementation under the hood, and can take other composable | ||
| * inside. | ||
| */ |
Member
There was a problem hiding this comment.
Suggested change
| /** | |
| * This class is responsible to map the Jetpack compose components which have "backgroundColor" & "contentColor" | |
| * in the parameter list, these components are mostly container components such as [BottomNavigation], [TopAppBar] | |
| * and [TabRow], etc.., they usually have a [Surface] implementation under the hood, and can take other composable | |
| * inside. | |
| */ | |
| /** | |
| * This class is responsible for the mapping of the Jetpack Compose components which have "backgroundColor" & "contentColor" | |
| * in the parameter list. These components are mostly container components such as [BottomNavigation], [TopAppBar] | |
| * and [TabRow], etc. They usually have a [Surface] implementation under the hood, and can take other composable | |
| * inside. | |
| */ |
mariusc83
previously approved these changes
Aug 13, 2024
0xnm
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TabRowCompositionGroupMappertoSurfaceCompoitionGroupMapper, because the way it maps the wireframe can be reused in a lot of Jetpack compose container components such as BottomNavigation, TopAppBar, TabRow.Motivation
RUM-5780
Review checklist (to be filled by reviewers)