Remove image property from macOS-based jobs#2181
Merged
0xnm merged 1 commit intoAug 12, 2024
Merged
Conversation
mariusc83
approved these changes
Aug 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2181 +/- ##
===========================================
+ Coverage 70.01% 70.05% +0.04%
===========================================
Files 726 726
Lines 27002 27001 -1
Branches 4525 4525
===========================================
+ Hits 18904 18913 +9
+ Misses 6830 6817 -13
- Partials 1268 1271 +3 |
jonathanmos
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
macOS runners are not using Docker, so
imageproperty is meaningless.Review checklist (to be filled by reviewers)