Remove redundant build configuration in new reliability modules#2178
Merged
0xnm merged 1 commit intoAug 12, 2024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2178 +/- ##
===========================================
- Coverage 70.01% 69.94% -0.07%
===========================================
Files 726 726
Lines 26997 27001 +4
Branches 4525 4525
===========================================
- Hits 18900 18885 -15
- Misses 6829 6831 +2
- Partials 1268 1285 +17 |
mariusc83
approved these changes
Aug 12, 2024
mariusc83
left a comment
mariusc83
left a comment
Member
There was a problem hiding this comment.
I would like OkHttp there and Gson as the reason I left them there is to anticipate the need for a mock web server and a Gson deserializer later.
Member
Author
|
@mariusc83 let's add them once needed, maybe we will need JSON assestion/OkHttp Mock Web server not in the stub module, but in the tests module. |
0xnm
deleted the
nogorodnikov/remove-redundant-build-configuration-in-new-reliability-modules
branch
August 12, 2024 12:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removing things that are not used/already declared to speed up build configuration.
Review checklist (to be filled by reviewers)