RUM-4738: Add "Tab" and "TabRow" Composable groups mappers#2171
Merged
Conversation
ambushwork
force-pushed
the
yl/add-tab-compose-support
branch
from
August 7, 2024 13:44
b87350d to
15eb3df
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/sr_compose #2171 +/- ##
======================================================
+ Coverage 82.13% 82.39% +0.26%
======================================================
Files 512 514 +2
Lines 18295 18353 +58
Branches 2814 2821 +7
======================================================
+ Hits 15026 15121 +95
+ Misses 2506 2470 -36
+ Partials 763 762 -1
|
ambushwork
force-pushed
the
yl/add-tab-compose-support
branch
from
August 8, 2024 08:54
15eb3df to
c80b414
Compare
mariusc83
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add "Tab" and "TabRow" Composable groups mappers, so that "Tab" & "TabRow" can have:
Motivation
RUM-4738
Demo
(The other components in the screen is a bit glitchy, but
TabandTabRowis working)https://mobile-integration.datadoghq.com/rum/replay/sessions/0d175d4a-4087-4cc9-8abc-fe22ee7d3c0e?applicationId=38030dde-f9f9-4e52-9443-b9804a030080&seed=e05a16d0-ea37-4f5b-b4fd-2ff7f27fe3fb&ts=1723037890870
Review checklist (to be filled by reviewers)