RUM-4710 Make sure network local spans have kind:client tag#2136
Merged
mariusc83 merged 1 commit intoJul 24, 2024
Merged
Conversation
mariusc83
force-pushed
the
mconstantin/rum-4710/networks-spans-are-identified-as-client-spans
branch
from
July 23, 2024 16:18
6bd769b to
7420e6f
Compare
mariusc83
marked this pull request as ready for review
July 23, 2024 16:19
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2136 +/- ##
===========================================
- Coverage 70.00% 69.97% -0.04%
===========================================
Files 726 726
Lines 26972 26962 -10
Branches 4520 4519 -1
===========================================
- Hits 18881 18864 -17
+ Misses 6826 6823 -3
- Partials 1265 1275 +10
|
jonathanmos
approved these changes
Jul 24, 2024
ambushwork
approved these changes
Jul 24, 2024
mariusc83
deleted the
mconstantin/rum-4710/networks-spans-are-identified-as-client-spans
branch
July 24, 2024 09:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)