[RUM-5566] Added setSyntheticsAttribute in RumInternalProxy#2133
Merged
marco-saia-datadog merged 1 commit intoAug 1, 2024
Merged
Conversation
marco-saia-datadog
force-pushed
the
marcosaia/RUM-5566/set-synthetics-attribute-api
branch
3 times, most recently
from
July 23, 2024 15:00
ef32fea to
6ef3f99
Compare
marco-saia-datadog
marked this pull request as ready for review
July 23, 2024 15:00
mariusc83
reviewed
Jul 23, 2024
xgouchet
reviewed
Jul 23, 2024
marco-saia-datadog
force-pushed
the
marcosaia/RUM-5566/set-synthetics-attribute-api
branch
from
July 24, 2024 12:42
6ef3f99 to
5de46e9
Compare
marco-saia-datadog
changed the title
mariusc83
approved these changes
Jul 26, 2024
xgouchet
approved these changes
Jul 29, 2024
marco-saia-datadog
force-pushed
the
marcosaia/RUM-5566/set-synthetics-attribute-api
branch
from
July 29, 2024 09:39
5de46e9 to
e33b3f2
Compare
Member
Author
|
I have added a check to verify that the lateinit variable if (::sdkCore.isInitialized) {
/// ...
}A test was failing because of this missing check, as the previous implementation would only use the @mariusc83 @xgouchet let me know if you prefer to modify the test instead, or if you think this approach is safer. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2133 +/- ##
===========================================
- Coverage 69.99% 69.97% -0.02%
===========================================
Files 726 726
Lines 26984 26995 +11
Branches 4520 4524 +4
===========================================
+ Hits 18887 18889 +2
- Misses 6827 6828 +1
- Partials 1270 1278 +8
|
marco-saia-datadog
force-pushed
the
marcosaia/RUM-5566/set-synthetics-attribute-api
branch
2 times, most recently
from
July 29, 2024 14:00
7020aae to
169ddb0
Compare
marco-saia-datadog
force-pushed
the
marcosaia/RUM-5566/set-synthetics-attribute-api
branch
from
August 1, 2024 09:42
169ddb0 to
13008c3
Compare
marco-saia-datadog
deleted the
marcosaia/RUM-5566/set-synthetics-attribute-api
branch
August 1, 2024 12:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
setSyntheticsAttributein_RumInternalProxyfor internal usage in cross-platform frameworks.Review checklist (to be filled by reviewers)