RUM-5389: Add API to configure the Image Privacy#2125
Merged
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-5389/image-recording-config
branch
2 times, most recently
from
July 17, 2024 08:08
3225f69 to
fe8bcf9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2125 +/- ##
===========================================
+ Coverage 70.03% 70.07% +0.05%
===========================================
Files 721 722 +1
Lines 26773 26847 +74
Branches 4499 4504 +5
===========================================
+ Hits 18749 18813 +64
- Misses 6771 6774 +3
- Partials 1253 1260 +7
|
jonathanmos
force-pushed
the
jmoskovich/rum-5389/image-recording-config
branch
from
July 17, 2024 11:35
fe8bcf9 to
bb9aeca
Compare
jonathanmos
changed the title
jonathanmos
force-pushed
the
jmoskovich/rum-5389/image-recording-config
branch
from
July 17, 2024 11:48
bb9aeca to
1f40138
Compare
jonathanmos
marked this pull request as ready for review
July 17, 2024 12:12
mariusc83
requested changes
Jul 17, 2024
0xnm
reviewed
Jul 17, 2024
mariusc83
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Link to the RFC
Adds an ImagePrivacy api to the SessionReplayConfiguration. The api has the following values:
MASK_ALL - no images will be recorded. Images will be replaced with a placeholder labelled "Image".
MASK_CONTENT - bundled images will be recorded and contextual ones will not (the default state). Contextual images will be replaced with a placeholder labelled "Content Image".
MASK_NONE - all images will be recorded.
Usage of the api:
MASK_NONE
MASK_CONTENT
MASK_ALL
Motivation
Give users the flexibility to have different image recording levels for their sessions.
Review checklist (to be filled by reviewers)