RUM-3634: Apply privacy settings to TextCompositionGroupMapper for compose#2121
Merged
Conversation
ambushwork
force-pushed
the
yl/compose-sr-privacy
branch
from
July 4, 2024 19:05
c381c5e to
7621d7a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/sr_compose #2121 +/- ##
======================================================
+ Coverage 81.95% 82.13% +0.18%
======================================================
Files 512 512
Lines 18291 18295 +4
Branches 2813 2814 +1
======================================================
+ Hits 14989 15026 +37
+ Misses 2538 2506 -32
+ Partials 764 763 -1
|
xgouchet
reviewed
Jul 5, 2024
ambushwork
force-pushed
the
yl/compose-sr-privacy
branch
from
July 5, 2024 15:39
7621d7a to
a87ba4b
Compare
xgouchet
previously approved these changes
Jul 10, 2024
ambushwork
force-pushed
the
yl/compose-sr-privacy
branch
from
July 10, 2024 14:09
a87ba4b to
f529eb6
Compare
Member
Author
|
@xgouchet I just rebased the branch due to some merge conflicts |
jonathanmos
reviewed
Jul 11, 2024
| } | ||
|
|
||
| @RepeatedTest(8) | ||
| fun `M return to correct wireframe W map`() { |
Member
There was a problem hiding this comment.
Suggested change
| fun `M return to correct wireframe W map`() { | |
| fun `M return the correct wireframe W map`() { |
| SessionReplayPrivacy.MASK_USER_INPUT -> if (fakeUiContext.isInUserInputLayout) { | ||
| FIXED_INPUT_MASK | ||
| } else { | ||
| String() |
Member
There was a problem hiding this comment.
question: why String() preferred over ""?
Member
Author
There was a problem hiding this comment.
personal habit of giving a empty string : ) now fixed
| } | ||
| } | ||
| .setPrivacy(SessionReplayPrivacy.MASK_USER_INPUT) | ||
| .setPrivacy(SessionReplayPrivacy.MASK) |
Member
There was a problem hiding this comment.
minor: what is the reason for this change?
Member
Author
There was a problem hiding this comment.
for the test purpose, it shouldn't be in the commit, reverted now
jonathanmos
previously approved these changes
Jul 11, 2024
ambushwork
force-pushed
the
yl/compose-sr-privacy
branch
from
July 11, 2024 08:46
f529eb6 to
56b3fe3
Compare
xgouchet
approved these changes
Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Apply the privacy settings to
TextCompositionGroupMapperfor compose, the text masking strategy keeps same asTextViewMapperin Android ViewMotivation
Screenrecord
Additional Notes
StringObfuscatoris changed frominternalclass to@InternalApi, so the class can be shared between module.Review checklist (to be filled by reviewers)