Update custom detekt CI Job#2118
Merged
Merged
Conversation
xgouchet
force-pushed
the
xgouchet/ci_memory
branch
4 times, most recently
from
July 3, 2024 09:00
4f1fef0 to
8a03361
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2118 +/- ##
===========================================
- Coverage 69.91% 69.85% -0.06%
===========================================
Files 727 730 +3
Lines 27112 27141 +29
Branches 4572 4569 -3
===========================================
+ Hits 18954 18958 +4
- Misses 6872 6905 +33
+ Partials 1286 1278 -8 |
xgouchet
force-pushed
the
xgouchet/ci_memory
branch
16 times, most recently
from
July 4, 2024 09:00
37884e5 to
f8b7785
Compare
xgouchet
force-pushed
the
xgouchet/ci_memory
branch
2 times, most recently
from
July 16, 2024 09:10
f00b9a8 to
a9e899c
Compare
xgouchet
force-pushed
the
xgouchet/ci_memory
branch
from
August 1, 2024 09:19
a9e899c to
bf6b5de
Compare
xgouchet
force-pushed
the
xgouchet/ci_memory
branch
from
August 26, 2024 11:41
bf6b5de to
c9276ac
Compare
xgouchet
force-pushed
the
xgouchet/ci_memory
branch
2 times, most recently
from
September 11, 2024 08:28
d6ef34e to
cb652c9
Compare
xgouchet
marked this pull request as ready for review
September 11, 2024 08:55
0xnm
reviewed
Sep 11, 2024
Comment on lines
+113
to
+115
| # DETEKT_CUSTOM_RULES_BUILD_TASK: "assembleLibrariesRelease :tools:detekt:jar" | ||
| # DETEKT_CUSTOM_RULES_JAR_PATH: "tools/detekt/build/libs/detekt.jar" | ||
| # DETEKT_CUSTOM_RULES_YML_PATH: "detekt_custom.yml" |
Comment on lines
+132
to
+133
| - unzip dd-sdk-android-core/build/outputs/aar/dd-sdk-android-core-release.aar -d dd-sdk-android-core/build/outputs/aar/ | ||
| - unzip features/dd-sdk-android-session-replay/build/outputs/aar/dd-sdk-android-session-replay-release.aar -d features/dd-sdk-android-session-replay/build/outputs/aar/ |
Member
There was a problem hiding this comment.
why we are unpacking only these two?
Comment on lines
+136
to
+138
| - java -jar detekt-cli-1.23.4-all.jar --config detekt_custom.yml --plugins "tools/detekt/build/libs/detekt.jar" -i "dd-sdk-android-core" -ex "**/*.kts" --jvm-target 11 -cp "$(cat dd-sdk-android-core/detekt_classpath)" | ||
| - java -jar detekt-cli-1.23.4-all.jar --config detekt_custom.yml --plugins "tools/detekt/build/libs/detekt.jar" -i "features/dd-sdk-android-logs" -ex "**/*.kts" --jvm-target 11 -cp "$(cat features/dd-sdk-android-logs/detekt_classpath):dd-sdk-android-core/build/outputs/aar/classes.jar" | ||
| - java -jar detekt-cli-1.23.4-all.jar --config detekt_custom.yml --plugins "tools/detekt/build/libs/detekt.jar" -i "features/dd-sdk-android-ndk" -ex "**/*.kts" --jvm-target 11 -cp "$(cat features/dd-sdk-android-ndk/detekt_classpath):dd-sdk-android-core/build/outputs/aar/classes.jar" |
Member
There was a problem hiding this comment.
maybe we should put this invocation in the gradle task? this will allow us to avoid a lot of repetitive lines and where only the name of the module is changed.
xgouchet
force-pushed
the
xgouchet/ci_memory
branch
5 times, most recently
from
September 17, 2024 09:30
155e6b0 to
ae68f82
Compare
0xnm
approved these changes
Sep 17, 2024
xgouchet
force-pushed
the
xgouchet/ci_memory
branch
from
September 17, 2024 15:25
ae68f82 to
fb36314
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This task splits the detekt custom job to limit the RAM usage in CI