Skip to content

RUM-3741: Use BackpressureExecutor for SessionReplay event processing#2116

Merged
jonathanmos merged 1 commit into
developfrom
jmoskovich/rum-3741/backpressure-dataqueuehandler
Jul 2, 2024
Merged

RUM-3741: Use BackpressureExecutor for SessionReplay event processing#2116
jonathanmos merged 1 commit into
developfrom
jmoskovich/rum-3741/backpressure-dataqueuehandler

Conversation

@jonathanmos

Copy link
Copy Markdown
Member

What does this PR do?

Uses the BackpressureExecutor for session replay event processing.

Motivation

The session replay event loop can experience backpressure, especially in applications with an endless feed.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented Jul 1, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.14%. Comparing base (eaa15cd) to head (9abafaf).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2116      +/-   ##
===========================================
- Coverage    70.23%   70.14%   -0.09%     
===========================================
  Files          721      721              
  Lines        26761    26756       -5     
  Branches      4484     4487       +3     
===========================================
- Hits         18794    18767      -27     
- Misses        6718     6745      +27     
+ Partials      1249     1244       -5     
Files Coverage Δ
...nreplay/internal/recorder/SessionReplayRecorder.kt 96.75% <100.00%> (-0.13%) ⬇️

... and 23 files with indirect coverage changes

@jonathanmos
jonathanmos marked this pull request as ready for review July 1, 2024 09:55
@jonathanmos
jonathanmos requested review from a team as code owners July 1, 2024 09:55
@jonathanmos
jonathanmos merged commit e3a82d9 into develop Jul 2, 2024
@jonathanmos
jonathanmos deleted the jmoskovich/rum-3741/backpressure-dataqueuehandler branch July 2, 2024 10:22
@xgouchet xgouchet added this to the 2.12.x milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants