RUM-5077: Fix units for dropped nodes#2107
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2107 +/- ##
==========================================
Coverage ? 69.18%
==========================================
Files ? 700
Lines ? 26165
Branches ? 4406
==========================================
Hits ? 18101
Misses ? 6864
Partials ? 1200
|
jonathanmos
force-pushed
the
jmoskovich/rum-5077/fix-droppednode-units
branch
from
June 24, 2024 10:51
a42a745 to
e30675f
Compare
jonathanmos
marked this pull request as ready for review
June 24, 2024 11:16
0xnm
approved these changes
Jun 24, 2024
xgouchet
approved these changes
Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We're sending ns instead of ms in the error msg for dropped nodes, but still write "ms" in the message itself. This pr fixes the units in the message.
Motivation
Wrong units in the dropped nodes error.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)