RUM-4098: Add api to clear all datastore data#2096
Merged
jonathanmos merged 2 commits intoJun 30, 2024
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-4098/add-clear-datastore-api
branch
from
June 20, 2024 13:53
10e7f4c to
9379f41
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-4098/sessionreplay-datastore
branch
from
June 20, 2024 14:33
6436ddc to
91c43fb
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-4098/add-clear-datastore-api
branch
from
June 20, 2024 14:43
9379f41 to
2f10a34
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2096 +/- ##
===========================================
+ Coverage 69.65% 69.70% +0.06%
===========================================
Files 718 718
Lines 26650 26686 +36
Branches 4466 4474 +8
===========================================
+ Hits 18561 18601 +40
+ Misses 6875 6864 -11
- Partials 1214 1221 +7
|
jonathanmos
force-pushed
the
jmoskovich/rum-4098/add-clear-datastore-api
branch
from
June 24, 2024 08:15
2f10a34 to
95ec2df
Compare
jonathanmos
marked this pull request as ready for review
June 24, 2024 08:54
0xnm
reviewed
Jun 24, 2024
mariusc83
requested changes
Jun 25, 2024
jonathanmos
force-pushed
the
jmoskovich/rum-4098/sessionreplay-datastore
branch
from
June 25, 2024 13:06
bc635ab to
2e2c6f1
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-4098/add-clear-datastore-api
branch
2 times, most recently
from
June 26, 2024 13:02
640a71f to
4ce6a5e
Compare
0xnm
requested changes
Jun 27, 2024
0xnm
approved these changes
Jun 27, 2024
jonathanmos
force-pushed
the
jmoskovich/rum-4098/sessionreplay-datastore
branch
6 times, most recently
from
June 27, 2024 14:07
fa9f3b1 to
4641fbf
Compare
jonathanmos
force-pushed
the
jmoskovich/rum-4098/add-clear-datastore-api
branch
from
June 27, 2024 14:46
07dbe6c to
7286345
Compare
Base automatically changed from
jmoskovich/rum-4098/sessionreplay-datastore
to
develop
June 27, 2024 15:02
xgouchet
approved these changes
Jun 28, 2024
mariusc83
approved these changes
Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an api to delete all saved datastore entries.
Motivation
The core's clearAllData api should return the sdk to a fresh state and therefore requires removal of datastore information.
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)