RUM-4879: Granular telemetry sampling for mappers#2087
Merged
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-4879/fix-map-with
branch
2 times, most recently
from
June 17, 2024 16:06
ad2ec98 to
2cb01af
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2087 +/- ##
===========================================
+ Coverage 68.88% 68.97% +0.09%
===========================================
Files 708 708
Lines 26302 26275 -27
Branches 4424 4424
===========================================
+ Hits 18116 18121 +5
+ Misses 6984 6942 -42
- Partials 1202 1212 +10
|
jonathanmos
marked this pull request as ready for review
June 18, 2024 06:08
0xnm
approved these changes
Jun 18, 2024
jonathanmos
force-pushed
the
jmoskovich/rum-4879/fix-map-with
branch
from
June 18, 2024 07:41
2cb01af to
aa5a093
Compare
xgouchet
reviewed
Jun 18, 2024
Contributor
|
Important Shouldn't we target this to the latest release branch instead of develop, to publish an hotfix? Or are we planning a new release soon? |
jonathanmos
force-pushed
the
jmoskovich/rum-4879/fix-map-with
branch
from
June 18, 2024 10:59
005d23b to
2955529
Compare
xgouchet
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Have more granular telemetry sampling for mappers, using three levels - default, reduced and rare, with each level reducing the number of events by a factor of 10.
Motivation
At the moment the default sampling rate is producing far too many events for some mappers.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)