Remove System and Environment config source in the CoreTracer#2084
Merged
Conversation
mariusc83
force-pushed
the
mconstantin/more-core-tracer-cleanup
branch
from
June 14, 2024 11:56
81a4e47 to
be02165
Compare
0xnm
approved these changes
Jun 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2084 +/- ##
===========================================
+ Coverage 68.73% 69.03% +0.31%
===========================================
Files 719 708 -11
Lines 26571 26300 -271
Branches 4472 4424 -48
===========================================
- Hits 18262 18156 -106
+ Misses 7123 6939 -184
- Partials 1186 1205 +19
|
xgouchet
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We are removing the
SystemandEnvironmentconfig sources in theCoreTraceras we are not using those in the Android JVM.Motivation
What inspired you to submit this pull request?
Additional Notes
Given this is a quite important update I am not sure if we should merge it or not. Let me know your thoughts.
Review checklist (to be filled by reviewers)