Add OpenTelemetry Proguard rules for compile-only annotations#2080
Merged
0xnm merged 1 commit intoJun 12, 2024
Merged
Conversation
mariusc83
reviewed
Jun 12, 2024
mariusc83
reviewed
Jun 12, 2024
0xnm
force-pushed
the
nogorodnikov/add-otel-proguard-rules-for-compile-only-annotations
branch
from
June 12, 2024 14:39
58c09e3 to
88ff084
Compare
mariusc83
approved these changes
Jun 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2080 +/- ##
===========================================
- Coverage 68.73% 68.56% -0.17%
===========================================
Files 719 719
Lines 26571 26567 -4
Branches 4472 4472
===========================================
- Hits 18262 18214 -48
- Misses 7123 7138 +15
- Partials 1186 1215 +29 |
0xnm
deleted the
nogorodnikov/add-otel-proguard-rules-for-compile-only-annotations
branch
June 12, 2024 15:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There is the following Proguard error when trying to minify OpenTelemetry module:
In fact both these annotations are not needed in runtime, so it is safely to ignore them.
Review checklist (to be filled by reviewers)