Skip to content

RUM-4508 Add OpenTelemetry use case into the vendor-lib sample#2069

Merged
mariusc83 merged 1 commit into
feature/otel-supportfrom
mconstantin/rum-4508/add-otel-module-into-vendor-lib-app
May 31, 2024
Merged

RUM-4508 Add OpenTelemetry use case into the vendor-lib sample#2069
mariusc83 merged 1 commit into
feature/otel-supportfrom
mconstantin/rum-4508/add-otel-module-into-vendor-lib-app

Conversation

@mariusc83

Copy link
Copy Markdown
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 self-assigned this May 31, 2024
@mariusc83
mariusc83 requested review from a team as code owners May 31, 2024 08:24
@mariusc83
mariusc83 force-pushed the mconstantin/rum-4508/add-otel-module-into-vendor-lib-app branch from bf00776 to 881db37 Compare May 31, 2024 08:31
Comment thread sample/kotlin/build.gradle.kts Outdated

composeOptions {
kotlinCompilerExtensionVersion = libs.versions.androidXComposeCompiler.get()
composeOptions kotlinCompilerExtensionVersion = libs.versions.androidXComposeCompiler.get()

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind this, it is a problem with the commit

@mariusc83
mariusc83 force-pushed the mconstantin/rum-4508/add-otel-module-into-vendor-lib-app branch from 881db37 to 5951ec7 Compare May 31, 2024 08:44
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.23%. Comparing base (5e72fef) to head (5951ec7).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature/otel-support    #2069      +/-   ##
========================================================
- Coverage                 67.39%   67.23%   -0.16%     
========================================================
  Files                       733      733              
  Lines                     27022    27015       -7     
  Branches                   4573     4574       +1     
========================================================
- Hits                      18209    18162      -47     
- Misses                     7585     7638      +53     
+ Partials                   1228     1215      -13     

see 37 files with indirect coverage changes

@mariusc83
mariusc83 merged commit ee23810 into feature/otel-support May 31, 2024
@mariusc83
mariusc83 deleted the mconstantin/rum-4508/add-otel-module-into-vendor-lib-app branch May 31, 2024 09:44
@xgouchet xgouchet added this to the 2.11.x milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants