Fix the jctools proguard rules#2063
Merged
mariusc83 merged 1 commit intoMay 30, 2024
Merged
Conversation
mariusc83
commented
May 30, 2024
| -keepnames class io.opentracing.util.GlobalTracer { | ||
| public boolean isRegistered(); | ||
| } | ||
| -keepclassmembernames class org.jctools.** { *; } No newline at end of file |
Member
Author
There was a problem hiding this comment.
jctools classes are at the core of the CoreTracer consumer and we cannot easily get rid of. On the other hand jctools is not really compatible with Proguard as it is using Reflection under the hood and we will need to keep at least the class member names.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/otel-support #2063 +/- ##
========================================================
- Coverage 67.37% 67.30% -0.07%
========================================================
Files 733 733
Lines 27015 27025 +10
Branches 4572 4573 +1
========================================================
- Hits 18201 18189 -12
- Misses 7587 7615 +28
+ Partials 1227 1221 -6 |
0xnm
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)