Remove the dd-sketches dependency and related logic#2062
Conversation
| @@ -1 +1,2 @@ | |||
| -keepnames class java.util.function.Function { *; } No newline at end of file | |||
| -keepnames class java.util.function.Function { *; } | |||
| -dontwarn com.google.auto.** No newline at end of file | |||
There was a problem hiding this comment.
This was added in this PR just for more speed. It is required by the OpenTelemetry API dependency which complains in R8
There was a problem hiding this comment.
PR just for more speed
I'm not clear how does it speed up the things. I don't think we should add this line anyway, com.google.auto.* may exist in customer dependencies.
There was a problem hiding this comment.
it is not for speeding up it is just to not have a second PR sorry for the confusion :).
I actually wonder if we should use keep here and make sure these classes will never be obfuscated.
There was a problem hiding this comment.
I wonder if we should do anything about it here or just leave this on the customer side and mention in the docs ? In any case without any action from our side R8 fails when compiling the APK
2e81fd8 to
7efc7ef
Compare
7efc7ef to
868fd0a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/otel-support #2062 +/- ##
========================================================
+ Coverage 66.91% 67.30% +0.39%
========================================================
Files 737 733 -4
Lines 27244 27027 -217
Branches 4598 4573 -25
========================================================
- Hits 18228 18188 -40
+ Misses 7798 7616 -182
- Partials 1218 1223 +5
|
4 participants
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)