Improve telemetry from RecordedDataQueueHandler#2053
Merged
Conversation
xgouchet
force-pushed
the
xgouchet/record_queue_telemetry
branch
from
May 24, 2024 14:58
7b4f205 to
5432c3a
Compare
0xnm
approved these changes
May 24, 2024
|
|
||
| private fun isTooOld(currentTime: Long, recordedDataQueueItem: RecordedDataQueueItem): Boolean = | ||
| (currentTime - recordedDataQueueItem.recordedQueuedItemContext.timestamp) > MAX_DELAY_MS | ||
| private fun isTooOld(currentTime: Long, recordedDataQueueItem: RecordedDataQueueItem): Boolean { |
jonathanmos
approved these changes
May 26, 2024
xgouchet
force-pushed
the
xgouchet/record_queue_telemetry
branch
from
May 27, 2024 06:25
5432c3a to
d8e62f3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2053 +/- ##
===========================================
+ Coverage 83.18% 83.25% +0.07%
===========================================
Files 494 494
Lines 17734 17739 +5
Branches 2685 2685
===========================================
+ Hits 14752 14768 +16
+ Misses 2243 2238 -5
+ Partials 739 733 -6
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add more details in the telemetry for it to be actionnable