RUM-4260 Make CoreTracer code Java 7 compatible#2051
Merged
mariusc83 merged 6 commits intoMay 27, 2024
Merged
Conversation
mariusc83
force-pushed
the
mconstantin/rum-4260/make-core-tracer-java-7-compatible
branch
from
May 23, 2024 09:19
ffdc515 to
c15ef3b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/otel-support #2051 +/- ##
========================================================
+ Coverage 64.11% 66.82% +2.70%
========================================================
Files 759 734 -25
Lines 28307 27197 -1110
Branches 4753 4603 -150
========================================================
+ Hits 18148 18172 +24
+ Misses 8926 7798 -1128
+ Partials 1233 1227 -6
|
mariusc83
force-pushed
the
mconstantin/rum-4260/make-core-tracer-java-7-compatible
branch
from
May 23, 2024 09:45
c15ef3b to
bfa1fe0
Compare
mariusc83
marked this pull request as ready for review
May 23, 2024 11:38
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
mariusc83
force-pushed
the
mconstantin/rum-4260/make-core-tracer-java-7-compatible
branch
2 times, most recently
from
May 23, 2024 12:57
db7f966 to
c7f4205
Compare
mariusc83
force-pushed
the
mconstantin/rum-4260/make-core-tracer-java-7-compatible
branch
from
May 24, 2024 15:14
d758882 to
da0a254
Compare
xgouchet
approved these changes
May 27, 2024
0xnm
approved these changes
May 27, 2024
mariusc83
deleted the
mconstantin/rum-4260/make-core-tracer-java-7-compatible
branch
May 27, 2024 07:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this PR we are cleaning up the imported Java code for the
CoreTracerand make it Java 7 compatible in order to not require desugaring on Android 23 and below.The are several steps in achieving this:
CoreTraceras I realized that we will be needing this later for Context propagationjava.util.Base64,java.util.Map,java.util.Streamis being used in order to make it Java 7 compatibleHave in mind that maybe some more cleaning could be performed but I don't find this idea wise. What I could clean so far was code that I was really certain that it cannot affect the current functionality, it will not have any impact on the APM metrics and will not have repercussions later. We already went into trouble by removing the
Injectorwhich seemed not to be used for the moment and I just realized during this PR work that this will have a negative impact later.Motivation
What inspired you to submit this pull request?
Additional Notes
I performed a Profiling by analyzing the CPU consumption and Memory consumption while using the new Otel code and I could not see any potential issue (spike).
Review checklist (to be filled by reviewers)